Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/AKD-191: Added Azure 'Automated Backups Configured' Plugin and test cases #740

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

feature/AKD-191: Added Azure 'Automated Backups Configured' Plugin and test cases #740

wants to merge 8 commits into from

Conversation

ali-imran7
Copy link
Contributor

No description provided.

AkhtarAmir
AkhtarAmir suggested changes May 31, 2021
View reviewed changes
exports.js Outdated Show resolved Hide resolved
plugins/azure/appservice/automatedBackupsConfigured.js Outdated Show resolved Hide resolved
plugins/azure/appservice/automatedBackupsConfigured.js Outdated Show resolved Hide resolved
plugins/azure/appservice/automatedBackupsConfigured.js Outdated Show resolved Hide resolved
plugins/azure/appservice/automatedBackupsConfigured.js Outdated
Comment on lines 45 to 47

if (!backupConfig || backupConfig.err || !backupConfig.data) {
helpers.addResult(results, 2, 'Automated Backups are not configured for the webApp', location, webApp.id);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check for specific error

@CLAassistant
Copy link

CLAassistant commented Sep 14, 2021 •
edited
Loading

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ giorod3
✅ AkhtarAmir
❌ ali-imran7
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AkhtarAmir AkhtarAmir AkhtarAmir requested changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
help wanted reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ali-imran7 @CLAassistant @AkhtarAmir @giorod3